Thanks, yeah, most people don't realize how much work goes into writing a single line of production worthy code.
Easy to think if you know a bit of programming you can easily do 1000s of lines of code a day, but that will change once you need to get every single line of code reviewed.
And knowing everything you write will be included in your yearly review, where the bottom x% gets the pink slip:D
So yeah, production code quality is by definition much higher quality than open source.
So no, production code quality is not by definition much higher quality than open source. FTFY.
How can production quality code be better if it is written by people who cant apply logic correctly to an argument?
Your logic assumes a few things that clearly are not correct.
One is that every production house does things the same formalised way as you.
Another is that no open source projects do apply quality controls to the same degree as you specified.
Another is that the quality controls you specified equate to higher quality code.
Maybe I am being pedantic but I am guessing that is the nature of high quality production code. So it should be second nature to you.
I agree that more reviewing and more care helps create better coding but to paint all OSS as lower quality than commercial source code is a crock of shit.
There are probably better ways of measuring code quality,including things such as
what the user thinks of the code.
the complexity of what the codes does.
bug/issues currently open.
new bug/issue rate.
test coverage.
etc etc but you get the picture.
I think these are so much more important than just a code review. In the heartbeat bug the code was actually reviewed and signed off on.
And the vice president signing off, well that would be a joke in some companies.
@Jaxbird. I am not saying that there is anything wrong with your companies methodology just that your argument is flawed.
I am also fairly certain that if you say your company produces top quality code then I am sure it does.
It's just that I have seen such crap come out of big and small companies with all the QA in the world that I don't believe a corporate culture actually produces code as good as the top OSS projects.
And here is the one that gets me.
And yeah, 3rd party libraries, not allowed unless full source available, and full source passes the same security standards required for internally produced code. Any exception requires director level management approval.
We should trust your companies code even though it is almost certainly closed source?
HYPOCRISY writ large.