Help Again! My First PIC18F25K22 project should..but it doesn't blink a LED.

[SuzyC]

 |OI am a complete newbie to PIC18's but I am determined to learn all about it. Naturally, my first project would be a simple one to test basic operation, so I wrote the very short code below..but it doesn't quite work.

Does anyone see a problem with my code? I can't seem to find out what is wrong or missing!

I see that TMRx timers are quite complex to setup, perhaps I should have started out with TMR0..there are about a dozen settings to set and possibly set wrong with the 16-bit timers.
//----------------------------------------------
/* Test for PIC18F25K22 2015Jun16

   NOTE: Compiled with Hi-Tech P18 PRO 9.80

   My First PIC18F25K22 Program:

   Should slowly blinks a LED on cbit3 ..it does, no IRQ, used for a blink, just For-Next loop timed.
   A test to use low and high priority interrupts. cbit2 lights just for 50uSec when INT0 is triggered!
   A test code using INT0 falling edge IRQ to light a LED
   A test using the TMR1 overflow interrupt to blink LED on cbit2
   I see with my scope about a .1 uSec glitch (lo-->hi-->lo)on cbit3 8uSec before cbit3 0-->1 but  cbit3 then keeps LED lit for  about a second correctly. This is strange, unexpected and evil, seems like something is clearing PORTC.


  It should much faster blink a LED on cbit2 using low priority interrupt and TMR1, it doesn't!

  It looks like TMR1 is not running?  Why?

   So far: cbit3 LED blinks almost perfectly
   Alas, cbit2 LED does not respond to IRQ or TMR1 overflow and does not blink.

  If I give INT0IF its own  private I/O pin and its own LED to light in the high-priority interrupt,  the INT0IF interrupt works perfectly.
*/
#include <htc.h>
#include <string.h>
#include <stdio.h>
#include <math.h>
#include <P18f25k22.h>

/*
#pragma config FOSC=0x88;   //resets PRICLKEN bit5 of CONFIG1H
#pragma config PRICLKEN=0;  //Primary Clock is disabled using Internal clk
#pragma config FOSC=0x5;    //Coofig1H Default 0x2500    0001=0x25

#pragma config BORV=0;     //Config2L Vdd level for BOREN to reset at                 
#pragma config BOREN=0;    //BOREN Disabled
#pragma config PWRTEN=1;   //                           0002=0x1F
#pragma config WDTPS=0;    //Ratio of Number of Clocks/WDTimerTic
#pragma config WDTEN=0;    //WatchDog Enable Disabled   0003=0x3F ater erase

#pragma config MCLRE=1;  //Pin 1 is *MCLR reset, not I/O pin
#pragma config PBADEN=0; //PORTB<0:5>are I/O pins not A2d inputs after reset
#pragma config T3CMX=1;  //HFINTOSC is not delayed at startup
#pragma config CCP2MX=1; //CCP2 in/out is Mtplxd with RC2
#pragma config DEBUG=1;  //Background Debugger is disabled
#pragma config XINST=0;  //Extended instruction set DISABLED
#pragma config LVP=0;    //LV programming disabled
#pragma config STVREN=1; //Reset on Stack Overflow or Underflow Enabled
 Note: above just here for later use in my code instead of Magic Numbers
*/

                //IES0 Allows internal/external clock swithover in OSCCON but is not used in program
//CONFIG1 System Clock
               //Bit   7            6          5        4       <3:0>
               //    IESO       FCMEM     PRICLKEN  PLLCFG                                OSC SELECT
               // Int-Ext      FailSafe                      no effect 0010 Xtal
               // ClkSwEn    Clock Mon                                                             HFINTOSC  1000 INTHFOSC
               //    1=En       0=off       0=off              x                                     0x1000
               //OSCCON SCS=0 else no 64MHz PLL operation
               //In this program 64MHz PLL is disabled, only 16MHz INTOSCBlock until things are looking better

__PROG_CONFIG(1,0x8800);   //Internal Osc Block at 16MHz
__PROG_CONFIG(2,0x0);        //BOREN and WDTEN both disabled
__PROG_CONFIG(3,0xBD00);  //PBADEN disabled PORTB<5:0>are I/O, not A2d at reset
__PROG_CONFIG(4,0x85);
__PROG_CONFIG(5,0xC00F);  //CONFIG4 to CONFIG7 set Read and Write protects, not used
__PROG_CONFIG(6,0xE00F);  //All mem reads and writes are enabled, no protect
__PROG_CONFIG(7,0x400F); / /Default BulkErase settings for CONFIG4--CONFIG7


#pragma config IESO=1;       //Needs to be=1 for SCS to work to set clk source
#pragma config PBADEN=0;             
#pragma config WDTEN=0;    //WatchDog Enable and BOREN Disabled,  was 0x3F ater bulkerase


#define Off           0
#define OFF          0
#define off            0
#define On           1
#define ON           1
#define on            1
#define None        0


                               //Breaks the ports down into their bits
#define PB(port,bit)  ((unsigned) & (port)*8 + (bit))
static bit abit0 @ PB(PORTA,0);
static bit abit1 @ PB(PORTA,1);
static bit abit2 @ PB(PORTA,2);
static bit abit3 @ PB(PORTA,3);
static bit abit4 @ PB(PORTA,4);
static bit abit5 @ PB(PORTA,5);
static bit abit6 @ PB(PORTA,6);
static bit abit7 @ PB(PORTA,7);

static bit bbit0 @ PB(PORTB,0);
static bit bbit1 @ PB(PORTB,1);
static bit bbit2 @ PB(PORTB,2);
static bit bbit3 @ PB(PORTB,3);
static bit bbit4 @ PB(PORTB,4);
static bit bbit5 @ PB(PORTB,5);
static bit bbit6 @ PB(PORTB,6);
static bit bbit7 @ PB(PORTB,7);

static bit cbit0 @ PB(PORTC,0);
static bit cbit1 @ PB(PORTC,1);
static bit cbit2 @ PB(PORTC,2);
static bit cbit3 @ PB(PORTC,3);
static bit cbit4 @ PB(PORTC,4);
static bit cbit5 @ PB(PORTC,5);
static bit cbit6 @ PB(PORTC,6);
static bit cbit7 @ PB(PORTC,7);

static double        ttemp=0;     //one and only var used for brute force timing in main()


void interrupt high_priority(void)
{
  if (INT0IF)
   { INT0IF = 0;
       cbit2=1;
   }
  if (TMR1IF)
   {
       TMR1ON = 0;
       TMR1IF = 0;
       TMR1H = 0x80;
       TMR1L = 0x0;
       TMR1ON = 1;
       if(cbit2==0)
        { cbit2=1;
        }
       else cbit2=0;
   }

}//End of High-Priority ISR

void interrupt low_priority lp(void)
{

  if(INT0IF)
   { INT0IF=0;
     cbit2=1;
   }

  if (TMR1IF)
   {
       TMR1ON = 0;
       TMR1IF = 0;
       TMR1H  = 0x80;
       TMR1L  = 0x0;
       TMR1ON = 1;
       if(cbit2==0)
        { cbit2=1;
        }
       else cbit2=0;
   }
}// end of Low priority interrupt


//____________________________ MAIN ___________________________________
void main(void)
{

  OSCCON=0x70;  //Selects Int Osc Block Clk as internal clock source
  OSCTUNE=0x1F; //Highest Internal OSC Freq =16 MHz with OSCTUNE<0:5> sets freq abd PLLEN=bit6 sets turbo mode
                             //OSCTUNE<6:0>set freq 011111 =16MHz and turboed by PLL
 PLLEN=1;      //Enables PLL Fosc=Fosc*4 up to 64MHz with Internal 16MHz osc.
//PLLRDY        //Status Bit 1=PLL ON

  PORTB = 1;    //Note: if a PORTA,B,C set to I/O, bit state of PORT is random
  PORTA = 0;    //unless set by these instructions
  PORTC = 0;

  INTEDG0=0;    //interrupt on falling edge
  TRISB = 0x1;  //INTO pin set for digital input
  TRISA = 0x0;
  TRISC = 0x0;  //all outputs on PORTC

  T1GPOL=0;     //TMR1 Gate Settings
  T1G=0;
  T1GTM=0;        //Gate Toggle Mode turned off
  T1GSPM=0;     //Gate Single-Pulse mode disabled                 Not sure any TMR1 Gate Control stuff is needed, turned off
  T1GCON=(T1GCON & 0x9); //T1GSS=Timer1 Gate pin
  T1OSCEN=1;    //Enable TMR1 Clocking
  TMR1GE=1;
  TMR1H  = 0x0; //If this TMR1 is timing out, the scope must show it.
  TMR1L  = 0x0;
  T1CON  = 0b01001000; //Enables system clock as clock source for TMR1
                       //T1CKPS=00  1:1 prescaler of clock
  TMR1IP = 0;   //Low Priority interrupt enabled for TMR1.
  TMR1ON = 1;
  TMR1IF = 0;
  TMR1IE = 1;   //Enable TMR1 interrupt

  INT0IE = 1;   //Enable INT0 interrupt, it is always high priority
  INT0IF = 0;   //Not here reset?, probably needs to be reset in ISR

  IPEN   = 1;   //High and Low interrupts enabled

  PEIE=1;       //turn on any possibly needed interrupt enables
  PIE1=1;
  PIE2=1;
  GIEL=1;
  GIEH=1;       //Start the ball rolling (although is seems to shaped more like a brick)

                //Progress, cbit3 LED always kinda blinks at about 1 second interval on/off
                //Failure: 
                // ******  NOTE:  cbit2 LED does not blink!  ******** and even cbit2 doesn't stay lit with INT0 trigger


//----------------------------------------------------------------------
  Start:
  for(ttemp=0;ttemp<60000;ttemp++)//approx 1-second timed loop at 16MHz x 4
   {                    //cbit3 stays ON, as expected
     cbit3=1;       //There is a a 1K resistor connected to a LED to Vss
                         / /cbit3 blinks, cbit2 should and doesn't, won't even stay lit for more than 50uSecs or so
     if(TMR1IE==0)      //NOTE: there is a 1K to +5 pullup on bbit0 INTIO0 bbit1
      { TMR1ON=0;       //         There is a LED connected to Vss with a 1k
        cbit2=1;        //      resistor to cbit2 pin.
        TMR1H  = 0x0;   
        TMR1L  = 0x0;
        TMR1IF = 0;     //Something's wrong: No cbit2 blink!
        TMR1IE = 1;
        TMR1ON = 1;     //Start the timer to blink the cbit2 LED
      }
     INT0IE=0;          //First it is TMR1's job to blink the LED
     INT0IF=0;
   }
  for(ttemp=0;ttemp<60000;ttemp++) //Takes about a second at 16MHz x 4
   {
     if(TMR1IE==1)      //If I ground bbit0 the cbit2 LED should light steady
      { TMR1IE=0;       //N.O. Momentary switch connected from bbit0 to Vss
        cbit2=0;        //cbit2 stays off, something is wrong!
        TMR1ON=0;       //No blinking by TMR1, with only INT0 at work
        TMR1IF=0;       //TMR1 is turned off during this ttemp timed loop
      }

     cbit3=0;           //cbit3 turns off and stays o as expected
   
     TMR1IE = 0;        //TMR1 is turned off, only bbit0 INT0 working
     INT0IE = 1;
   }
  goto Start;
}
//========================   END of MAIN   ==================================

[22swg]

This looks wrong ? {}{} ?

Code: [Select]

  if (TMR1IF)
   {
       TMR1ON = 0;
       TMR1IF = 0;
       TMR1H  = 0x80;
       TMR1L  = 0x0;
       TMR1ON = 1;
       if(cbit2==0)
        { cbit2=1;
        }
       else cbit2=0;
   }
}// end of Low priority interrupt

[SuzyC]

Thanks Again, 22swg!

I can't see the problem you've see here..gimee a hint? Is it that I must add more code before attempting to modify TMR1H,L?
The code in question simply alternately toggles, blinks, turns on and off the LED on cbit2 with each TMR1 overflow interrupt. Interrupts are properly enabled, but the TMR1 perhaps never starts counting clocks.

If it is all possible for anyone to compile this masterpiece on their own IDE, and post the resulting intel .hex file, then I could check if this is some bug in my Hi-Tech P18 Pro compiler 9.80.
I saw that somewhere, someone on a coder forum said that 9.80 has a bug with interrupt priority code.

Interesting, I see in the .lst file created for this code that the high-priority interrupt was using interrupt level 2 and the low-priority interrupt was using interrupt level 1??

:040000002AEF00F0F3
:04000800BFEF04F052
:10001800D8CF01F0E8CF02F0E0CF03F09EA001D0E6
:1000280001D00DD0CD909E90D00ECF6ECE6ACD80EF
:1000380082B401D001D002D0828401D0829403C05E

The .hex file clearly shows code for the high-priority interrupt at address 0x0008 and the low-priority at location 0x0018.


It could also be my DIY programmer, but it does seem to be working quite perfect, it seems to verify the code burned into the MCU against the .hex file in all memory locations, so, I a flummoxed!


The beginning of the .lst file for the lp low-priority interrupt:

   73 ;;Total ram usage:        3 bytes
    74 ;; Hardware stack levels used:    1
    75 ;; Hardware stack levels required when called:    1
    76 ;; This function calls:
    77 ;;      Nothing
    78 ;; This function is called by:
    79 ;;      Interrupt level 1
    80 ;; This function uses a non-reentrant model
    81 ;;
    82                           
    83                              psect   intcodelo
    84  000018                     __pintcodelo:
    85                              opt stack 0
    86  000018                     _lp:
    87                              opt stack 26
    88  000018  CFD8 F001             movff   status,??_lp
    89  00001C  CFE8 F002             movff   wreg,??_lp+1
    90  000020  CFE0 F003             movff   bsr,??_lp+2
    91  000024                     
    92                           ;Test.c: 126: if(INT0IF)
    93  000024  A2F2                  btfss   intcon,1,c   ;volatile
    94  000026  D001                  goto   i1u4_21
    95  000028  D001                  goto   i1u4_20
    96  00002A                     i1u4_21:
    97  00002A  D002                  goto   i1l110
    98  00002C                     i1u4_20:
    99  00002C                     
   100                           ;Test.c: 127: { INT0IF=0;
   101  00002C  92F2                  bcf   intcon,1,c   ;volatile
   102                           
   103                           ;Test.c: 128: cbit2=1;
   104  00002E  8482                  bsf   3970,2,c
   105  000030                     i1l110:
   106                           
   107                           ;Test.c: 129: }
   108                           ;Test.c: 131: if (TMR1IF)
   109  000030  A09E                  btfss   3998,0,c   ;volatile
   110  000032  D001                  goto   i1u5_21
   111  000034  D001                  goto   i1u5_20
   112  000036                     i1u5_21:
   113  000036  D00D                  goto   i1l114
   114  000038                     i1u5_20:
   115  000038                     
   116                           ;Test.c: 132: {
   117                           ;Test.c: 133: TMR1ON = 0;
   118  000038  90CD                  bcf   4045,0,c   ;volatile
   119                           
   120                           ;Test.c: 134: TMR1IF = 0;
   121  00003A  909E                  bcf   3998,0,c   ;volatile
   122  00003C                     
   123                           ;Test.c: 135: TMR1H = 0x80;
   124  00003C  0E80                  movlw   128
   125  00003E  6ECF                  movwf   4047,c   ;volatile
   126  000040                     
   127                           ;Test.c: 136: TMR1L = 0x0;
   128  000040  6ACE                  clrf   4046,c   ;volatile
   129  000042                     
   130                           ;Test.c: 137: TMR1ON = 1;
   131  000042  80CD                  bsf   4045,0,c   ;volatile
   132  000044                     
   133                           ;Test.c: 138: if(cbit2==0)
   134  000044  B482                  btfsc   3970,2,c
   135  000046  D001                  goto   i1u6_21
   136  000048  D001                  goto   i1u6_20
   137  00004A                     i1u6_21:
   138  00004A  D002                  goto   i1l112
   139  00004C                     i1u6_20:
   140  00004C                     
   141                           ;Test.c: 139: { cbit2=1;
   142  00004C  8482                  bsf   3970,2,c
   143                           
   144                           ;Test.c: 140: }
   145  00004E  D001                  goto   i1l114
   146  000050                     i1l112:
   147                           
   148                           ;Test.c: 141: else cbit2=0;

[picandmix]

This hex code runs on my 45k22 and flashes PortB,0 every 500ms. ( programmed with a Pk3)

Hopefully it will prove your programmer ..?

[22swg]

Sorry being vague    , but should there not be an extra {  or is this ok in hitec ... but there again picandmix got it to run ?

Code: [Select]

{
       TMR1ON = 0;
       TMR1IF = 0;
       TMR1H = 0x80;
       TMR1L = 0x0;
       TMR1ON = 1;
       if(cbit2==0)
        { cbit2=1;
        }else{
        cbit2=0;
        }
        } 

[SuzyC]

Thanks 22swg, but the program compiles and Hi-tech never misses a miss-matched phrase of my poetry, look again to see there exits one } for every { .

But brother, can you spare me a.hex file?

[SuzyC]

Good show!, picandmix,  A thousand thanks!

BTW, is this like my code, using two priorities of interrupts?

[picandmix]

No, its written in Pic Assembly Code.

Its from an old project, just edited it to flash a led using a software delay so you had the proven 45K22 .hex code you wanted.

I have used a 32k crystal and Tmr1 with the high priority interrupt to run a RTC on a 18F4520 for years; works well.

[SuzyC]

OMG

I just burned your code into my breadboarded MCU and got quite a different story than was promised.

I see all ports pins are at Vss except for cbit2 and cbit3 which have identical, but odd pulse trains.

The waveform repeats every 4-seconds, it is active for 2 seconds an at Vss for two seconds.
When active the waveform consists of 2-mSec (lo) spaced 8-uSec(hi) square pulses for the entire two seconds.

This waveform looks like  a comb, and I m pulling out my hair!

To repeat, there is no activity on PORTA nor PORTB, PORTB.0 (bbit0) has a pull-up and remains at +Vdd.

I just don't get how my programmer can put these same bytes in the locations specified in the hex file, can repeatedly verify that they are indeed there and so I see that I write right addresses, yet I get these results on PORTC instead of PORTB, yet I can see all the CONFIG bytes match perfectly, and the 20-MHz Xtal attached to the proper pins is not active, Pin1 is *MCLR reset and resets properly, and it is obviously using the internal clock, and producing a kinda blink with a period of 4-seconds, 50% duty cycle comb waveform.

Could you or any other good samaritan run my hexfile on your PICKIT3 to see whatcha get?

[picandmix]

My code was using the internal osc and all the config parameters are within the .hex file.
Port A and E defined as input, all else as outputs.

Have just loaded your code and its flashing away on RC3 at 1 sec.

The first shot is my code, the second your code , config data at the top right ; programmed this time via the Pk2, but that can only be done using the stand alone program PK2 V2.61

[SuzyC]

Thanks a gadzillion, pickandmix, but cbit3 was the only pin timed by a for-next loop and was working correctly, (almost, there is a mysterious 8-uSec glitch I've mentioned above.) 

Please note that cbit2 is the problem pin. The cbit2 pin shows the actions of all the interrupts and TMR1 count operation.

You hexed help is just what a damsel coder in distress needed.

I can see that my super-duper suzyburn pickit clone might be somehow clowning me ...or is it?

I will use the memory read function of my device to see what is the difference between what is read and what is wrote. It seems to be putting the bytes in the right places, but if I could get a mem dump of your correctly programmed chip, then I could compare the actual bytes read from your MCU to what I read from my MCU.   

The trouble might be in the first code, the interrupt routines, but you show your screenshot of code.. (is this a dump of the MCU..or is it the hex code file)?  But then the screenshot of my code(again, is this the hex file or MCU dump??) display starts at location 0x0030.

Very hard to compare the two, but hanks again for taking the effort to  help!

[picandmix]

I do not have every pin of the 45k22 on a led, have just checked all other pins with a dmm and no other pins seem active, some high, some low .

Think I mentioned early on about your initial diy programmer problems that a breadboard can give strange problems, partic if using and external crystal and caps, their fine leads can 'loose' the signals.

Also the length of wire between the programmers output and the breadboard should be as short as possible, less that 100mm ideal.

Would not start moving code around after its been complied, you will just get errors.

My code example has these config settings and Oscon is set to 8mhz
( ignore the eeprom data in my old code, forget to remove it )

;    CONFIG directives for 18F45K22
;
;   All Code and Memory Protections  are OFF, see .INC file for details if needed.


     ;Setup CONFIG11H
     CONFIG FOSC = INTIO7, PLLCFG = OFF, PRICLKEN = OFF, FCMEN = OFF, IESO = OFF
     ;Setup CONFIG2L
     CONFIG PWRTEN = OFF, BOREN = OFF, BORV = 190
     ;Setup CONFIG2H
     CONFIG WDTEN = OFF, WDTPS = 1
     ;Setup CONFIG3H
     CONFIG MCLRE = INTMCLR, CCP2MX = PORTB3, CCP3MX = PORTE0, HFOFST = OFF, T3CMX = PORTB5, P2BMX = PORTD2
     ;Setup CONFIG4L
     CONFIG STVREN = OFF, LVP = OFF, XINST = OFF
     ;Setup CONFIG5L
     CONFIG CP0 = OFF, CP1 = OFF, CP2=OFF, CP3=OFF
     ;Setup CONFIG5H
     CONFIG CPB = OFF, CPD = OFF
     ;Setup CONFIG6L
     CONFIG WRT0 = OFF, WRT1 = OFF, WRT2 = OFF, WRT3 = OFF
     ;Setup CONFIG6H
     CONFIG WRTB = OFF, WRTC = OFF, WRTD = OFF
     ;Setup CONFIG7L
     CONFIG EBTR0 = OFF, EBTR1 = OFF, EBTR2 = OFF, EBTR3 = OFF
     ;Setup CONFIG7H
     CONFIG EBTRB = OFF

[SuzyC]

Thanks again picandmix, but I am quite sure the trouble is not a HW problem.
There are no Xtals, used, no external MCU,  the interface is directly to just four PC Parallel Port pins via some open-collector LSTTL gates. I have scoped the Pdat and PClk data carefully and both waveforms are very clean and required delays required in the programming timing diagrams in every case exceed the Min. specs  by a large margin.

My very first attempt to verify correct operation didn't use any interrupts, but still, there were anomalies in the clock waveforms.

When I use exactly the same hardware, but of course, different code, to program 16F88x chips there is never a problem.

Methinks there is something softwarish screwy.

[SuzyC]

Do Pickit2/3 allow to dump the burned contents of a MCU programmed unprotected to a file?

Maybe that isI would like to see to get to the core of the problem.

But how can my programmer read all the bytes at their proper location and consistently and match them to their correct addresses in the .hex file and yet the MCU result is completely psycho.

[picandmix]

Cannot answer all your questions but as you can see from those PK2 screen shots you can see the program code to be burnt in the Program Memory panel.

Don't know what software you are using to burn your code, but most have a similar buffer/ panel to see and even edit the hex code.

Also once burnt you should have a verify sequence which should confirm the buffer and chip hold the same code and importantly the same config paramenters.

As in that screenshot you can see where I have actually read the chip code back into the buffer before reprogramming it, so you can do a visual inspection of whats been burnt.

If my basic code did not run properly then it sounds like you are still getting problems with yo programmer routine /hw ??  - though must confess I did not follow all of your previous long  thread on that ...



Just one point on your  C code, (which  I do not know/ use), you have this Config which sets port B to digital, but I do not see any use of ANSEL to set all the other ports to Digital, the power on default is analogue Input.
In Assembly  you have to manual tell it / use ANSELs  to make them digital, don't know if C does it automatically ??

#pragma config PBADEN=0; //PORTB<0:5>are I/O pins not A2d inputs after reset

[Skimask]

RTFDS

Section 10.1 - Note:

Section 10.3.1 - Note:

Section 10.4 - Note:

[Bruce Abbott]

how can my programmer read all the bytes at their proper location and consistently and match them to their correct addresses in the .hex file and yet the MCU result is completely psycho.

It may be storing bytes in the wrong locations. If read out of the same wrong locations it will appear to be correct, but the code will not work properly.

The obvious way to find where your programmer is actually writing the data is to read it back with another programmer that is known to work correctly. But of course to do that you need another programmer, which I am guessing you don't have (otherwise why bother making your own?).  However you do have a PC with a parallel port, so you could try building a programmer such as the Oshonsoft Parallel Port PIC-PIC18 Programmer (http://www.oshonsoft.com/picprogparallel.html) which supports the 18F26K22 and so should be able to read the 18F25K22.


 

[SuzyC]

Many thanks Skimask, this is an epiphany. Thank you very much for pointing this out to me.

 I can see how pin function prioritization could explain the glitches because another function is also trying to output to the same pin.

I know I am a newbie to this chip, it just seemed so non-intuitive that an I/O pin would allow another function to be active on that same pin, since I always assumed that the alternate function of a bin had to be software enabled to have that effect.

In the case of the P18F25K22, it seems that other functions than simple I/O  can be the default function. Silly me, I thought they just needed be just TRIS'd to become outputs.

That being the case, I still will certainly study more carefully how to initialize the MCU pins I am using and RTFM!

That's a big 10-4, Skimask!

 

[SuzyC]

thanks, Bruce Abbot, but this sounds more like a science-fiction story than reality. Unless an obfuscation function was enabled by code read/write protect bits, this scenario is just not possible without it being front page news in the specsheet for programming this device, for which I have RTFM. 

Perhaps Skimask has better defined the problem, the code might be correctly programmed into the MCU but the code is defective because the code's target pins are configured wrong.

Garbage In--->Garbage Out!

Fascinating, picandmix programmed one of his own with my .hex file and then tested the only pin that was working correctly(at first glance) and then reports that my program works.

[SuzyC]

Thanks again Bruce Abbot,

I downloaded the Parallel Port programmer from the link you provided and installed the  .exe program.

The program crashed and closed while I was only attempting to select a device to be programmed.

At least it is a free program. Program was written by Vladimir Soso.

I would say this software is validly just so-so.

[SuzyC]

Two questions remain:

1) Does Hi-Tech P18 PRO have a bug that miscodes interrupt priority?
Although I could get the program to work in its own crippled way, it never responded to a low-priority interrupt, but did respond in compatibility mode single ISR mode.

2)Is my DIY programmer really defective..A sure way to prove this would for someone to download the .hex file I've posted and tell me that they get different results or for someone else to  provide a test or another program's .hex file that is known to work properly even just blinking a LED or two and responding to low and high priority interrupts with the 18F25K22.

So far, I am still not certain where the problem lies.

[Bruce Abbott]

Perhaps Skimask has better defined the problem, the code might be correctly programmed into the MCU but the code is defective because the code's target pins are configured wrong.

Two identical chips programmed with the same hex file should work the same. picandmix's hex works in his chip, but not yours. Your code also works in his chip, but not in yours. The only difference is the programmer, so unless you have a hardware fault (broken chip, bad wiring etc.) the obvious conclusion is that your chip is not being programmed correctly. 

I downloaded the Parallel Port programmer from the link you provided and installed the  .exe program.

The program crashed and closed while I was only attempting to select a device to be programmed.

Weird... works fine on my PC, which doesn't even have a parallel port!  Here's another one that might work better for you:-

meProg 4.52.0 Beta (use with circuit below) http://melabs.com/support/progsoft.htm
pic³prog parallel port programmer http://urriellu.net/en/projects-electronics/pic3prog-pic-programmer-parallel-port.html

[Bruce Abbott]

Can you explain this anomaly? Number in hex file doesn't match source code.

Your source code:-

void interrupt low_priority lp(void)
{

  if(INT0IF)
   { INT0IF=0;
     cbit2=1;
   }

  if (TMR1IF)
   {
       TMR1ON = 0;
       TMR1IF = 0;
       TMR1H  = 0x80;
       TMR1L  = 0x0;
       TMR1ON = 1;
       if(cbit2==0)
        { cbit2=1;
        }
       else cbit2=0;
   }
}// end of Low priority interrupt


Your hex file disassembled:-

0030 0ED0 MOVLW 0xd0
0032 6ECF MOVWF 0xfcf ; TMR1H

[picandmix]

Probably not what you want to hear, but like many I also started off with the diy pic programmers but soon found they were very limiting and problematic.

While I admire your tenacity in trying to build you own programmer and software, I found that with then such a limited knowledge it would be pointless me then trying to do the same so I opted to purchase a then quiet expensive PK2.

Since then I never looked back, the Pk2 gave 100% reliable programming of most hobbyist chips, plus added extas like programmer to go, usart and logic analyzer tools.

It then lets you concentrate on leaning how to complete and test your projects without the worry of  'is it being programmed right ? '

The plans Bill showed for the Pk2 basic clone will, with a updated  Pk2 .dat file, program many 18F J and K series chips via its V2.61  free program , as you can see from my screenshots.
The catch is that with these later chips it that they cannot be programmed direct from Mplab IDE and cannot be run from Mplabs IDE  Debugger, for that you have to use a Pk3 ( which is not a practical diy build)

I was about to say I would post you over a programmed 2550 chip so you could build your own Pk2 clone, but it hardly seems worth it when you can get a complete Pk2 for less than $10


EDIT
Footnote  - even if you manage to sort out the software for the 18F45K22 programming, are you going to go through the same exercise for each new family of Pic you advance on to  , eg 18F J , Pic24, Pic32 etc etc ??

[lewis]

Pickit 2 is still available from Farnell, grab 'em while you can!

http://uk.farnell.com/microchip/dv164120/programmer-pickit2-for-pic/dp/9945350

[SuzyC]

Thanks for your comments, Bruce Abbot,

The difference between the 0x0d and 0x80 is due to a minor modification that revised the .hex file slightly.
I made his change to make sure that TMR1 had fewer counts to count since I was worried the time allotted to TMR1 by the SW only loop might expire before TMR1. I apologize for not updating my original post while posting a slightly changed .hex file.

I thought this change was insignificant and not affecting the greater problem of having no blink and no low-priority ISR working.

Thanks picandmix, especially for your generosity for offering me a chip. Although this programmer may still be a work in progress, I am very satisfied with what I have created and I truly enjoy the fact that I can modify my HW/SW to fit my fancy at anytime.

To me this is priceless.

I also know that future modifications required  for other chips will be rather trivial.

I think my programmer is working properly, but now I realize that I must also RTFM to know how a chip works to create a test program clever enough to test my programmer.

Please, someone send me a .hex file for a simple program known to work properly, one that will test the operation of priority interrupts with the 18Fx5K22 or similar.

[SuzyC]

Thanks Lewis, for allowing me to find a way to spend almost $500 um...more like $100 USD on something I can build myself..as you can see.

This link is just another link to the poorhouse.

[SuzyC]

Thanks picandmix, I ebayed the Pickit2 and see it is currently available from Hong Kong. 

I've tried, but Ijust can't get used to the up to 2-month delay in delivery due to snail mail by boat and customs, etc. In this period of time I could build my own! The site says delivery between Jun. 30 and Fri. Jul. 17

There are other issues at stake here, the low price may mean that the device may be poorly constructed, or not actually work or it is a scam. If I find that this device is being sold by a reputable ebay store, I could probably return it for a full refund, just have to wait a month for it to get back to Hong Kong (by boat, and maybe by this time election issue riots have caused China's hard hand policy to just nuke the whole area), I could then wait another month or so for a replacement to arrive.
I recently purchased a set of different tweezers for SMD work, seemed to be bargain price, and they never, ever arrived, just a <$20 deal, but money lost all the same.

In any case, if I had a pickit2 or 3 or whatever, if my dog decided the plastic thing was tasty or if I somehow managed to blow its #@#7@! brains out I wouldn't be able to fix it myself and would have to wait another 1 to 2 months for another or pay a king's ransom to buy one locally.

[senso]

Thanks Lewis, for allowing me to find a way to spend almost $500 USD on something I can build myself..as you can see.

This link is just another link to the poorhouse.

500$ where???
An original PicKit3 costs less than 50$ 

[picandmix]

Yes, Ebay China can be gamble, though I only order lo value items to avoid import duties and taxes.
Normally only takes 10 -14 days from China.

Please, someone send me a .hex file for a simple program known to work properly, one that will test the operation of priority interrupts with the 18Fx5K22 or similar.

Am sure the K22 will do such functions like all the other chips, but cannot see how that will help you with your programmer problem.

If no one comes up with such code for you, then I will do some for you later tonight

In the mean time, surely the best way would be to do a most basic program using a basic 4 or 8 mhz internal osc and just turn one ports outputs to high and another ports outputs to low; and nothing more.
That should work on your chip /progammer.

If it does not, then send your .hex code for me to test on my k22 dev board.

[lewis]

Thanks Lewis, for allowing me to find a way to spend almost $500 USD on something I can build myself..as you can see.

This link is just another link to the poorhouse.

Not sure where you got 500 bucks from. Pickit3 is even cheaper and more current.

[SuzyC]

Senso, I just clicked on the link posted about this bargain.

[SuzyC]

Thanks again, picandmix, you are a nice guy to help so much.

I realized that I was creating my own troubles by making my test program overly complicated, so I thought more carefully and tried to write some code that was short and to the point.

The result is:
1) The chip now blinks the LEDS and has proved it can work correctly with in Priority Interrupt Mode and Hi-Tech 9.80 works.
     This is the short test and uses minimal code to do the job
2) I tested the program also by editing in the short version I just created into a monster c-source file that I does math and  has so much nonsense code that it uses 98.6% of available code space. Compiles and  works perfect as well.
//=============================== This One Works! ========================================
/* Test for PIC18F25K22 that works

   My Second PIC18F25K22 Program:

   Program only slowly blinks LEDs and shows operation of priority mode interrupts
*/
#include <htc.h>
#include <string.h>
#include <stdio.h>
#include <math.h>
#include <P18f25k22.h>

/*
#pragma config FOSC=0x8;   //By itself also sets PRICLKEN=1 bit5 of CONFIG1H
#pragma config PRICLKEN=1; //Primary Clock is always enabled
#pragma config FOSC=0x5;   //Coofig1H Default 0x2500    0001=0x25

#pragma config BORV=0;     //Config2L Vdd level for BOREN to reset at                 
#pragma config BOREN=0;    //BOREN Disabled
#pragma config PWRTEN=1;   //                           0002=0x1F
#pragma config WDTPS=0;    //Ratio of Number of Clocks/WDTimerTic
#pragma config WDTEN=0;    //WatchDog Enable Disabled   0003=0x3F ater erase

#pragma config MCLRE=1;  //Pin 1 is *MCLR reset, not I/O pin
#pragma config PBADEN=0; //PORTB<0:5>are I/O pins not A2d inputs after reset
#pragma config T3CMX=1;  //HFINTOSC is not delayed at startup
#pragma config CCP2MX=1; //CCP2 in/out is Mtplxd with RC2
#pragma config DEBUG=1;  //Background Debugger is disabled
#pragma config XINST=0;  //Extended instruction set DISABLED
#pragma config LVP=0;    //LV programming disabled
#pragma config STVREN=1; //Reset on Stack Overflow or Underflow Enabled
*/                       //Allow internal/external clock swithover in OSCCON
#pragma config IESO=1;   //Needs to be=1 for SCS to work to set clk source
#pragma config PBADEN=0;             
#pragma config WDTEN=0;    //WatchDog Enable Disabled   0003=0x3F ater erase
               //Bit   7      6          5        4       3210
               //    IESO   FCMEM     PRICLKEN  PLLCFG    OSC SELECT
               // Int-Ext   FailSafe            no effect 0010 Xtal
               // ClkSwEn   Clock Mon           HFINTOSC  1000 INTHFOSC
               //    1=En     0=off   1=En        x       1000
               //OSCCON SCS=0 to select above or else no 64MHz operation
__PROG_CONFIG(1,0x8800); //Internal Osc Block at 16MHz x 4 with PLL
__PROG_CONFIG(2,0x0);    //BOREN and WDTEN both disabled
__PROG_CONFIG(3,0xBD00); //PBADEN disabled PORTB<5:0>are I/O not A2d at reset
__PROG_CONFIG(4,0x85);
__PROG_CONFIG(5,0xC00F); //CONFIG4 to CONFIG7 set Read and Write protects
__PROG_CONFIG(6,0xE00F);
__PROG_CONFIG(7,0x400F);


#define Off           0
#define OFF           0
#define off           0
#define On            1
#define ON            1
#define on            1
#define None          0


                               //Break the ports down to their bits
#define PB(port,bit)  ((unsigned) & (port)*8 + (bit))
static bit abit0 @ PB(PORTA,0);
static bit abit1 @ PB(PORTA,1);
static bit abit2 @ PB(PORTA,2);
static bit abit3 @ PB(PORTA,3);
static bit abit4 @ PB(PORTA,4);
static bit abit5 @ PB(PORTA,5);
static bit abit6 @ PB(PORTA,6);
static bit abit7 @ PB(PORTA,7);

static bit bbit0 @ PB(PORTB,0);
static bit bbit1 @ PB(PORTB,1);
static bit bbit2 @ PB(PORTB,2);
static bit bbit3 @ PB(PORTB,3);
static bit bbit4 @ PB(PORTB,4);
static bit bbit5 @ PB(PORTB,5);
static bit bbit6 @ PB(PORTB,6);
static bit bbit7 @ PB(PORTB,7);

static bit cbit0 @ PB(PORTC,0);
static bit cbit1 @ PB(PORTC,1);
static bit cbit2 @ PB(PORTC,2);
static bit cbit3 @ PB(PORTC,3);
static bit cbit4 @ PB(PORTC,4);
static bit cbit5 @ PB(PORTC,5);
static bit cbit6 @ PB(PORTC,6);
static bit cbit7 @ PB(PORTC,7);

static double        ttemp=0;


void interrupt high_priority(void)
{
  if (INT0IF)      //When INT0IE is enabled, bbit1 lights and stays on when INTI0 is triggered falling edge
   { INT0IF = 0;   
     bbit1=1;
   }
  if (TMR1IF)
   {  TMR1IF=0;    //During the time INTI0 is enabled TMR1IF is manually set and bbit3 toggles with Sw press
      if(bbit3==0)   //In this case,  if TMR1IP=1, it is hi-priority, INT0 is always hi-priority
       { bbit3=1;
       }
      else bbit3=0;
   }
}//end of high-priority interrupt

void interrupt low_priority lp(void)
{
  if(INT0IF)       //During the time INT0IE=0 and TMR1IP = 0, lo-priority, INTIOF will be set in any case
   { INT0IF=0;     //by a swith press
     bbit1=0;      //I can tell I am in this mode also because bbit1 LED is not lit
   }
  if (TMR1IF)      //If TMR1IF is triggered by a Sw. press, bbit4 will toggle
   { TMR1IF=0;
     if(bbit4==0)
      { bbit4=1;
      }
     else bbit4=0;
   }
}// end of low priority interrupt


//____________________________ MAIN ___________________________________
void main(void)
{
Reset:

  OSCCON=0x70;  //Selects Int Osc Block Clk as internal clock source
  OSCTUNE=0x5F; //Highest Internal OSC Freq OSCTUNE<0:5> set freq. PLLEN=bit6
                //OSCTUNE<6:0>set freq 011111 =16MHz
  PLLEN=1;      //Enables PLL Fosc=Fosc*4 = 64MHz with Internal 16MHz osc.
//PLLRDY        //Status Bit 1=PLL ON


  INTEDG0=0;    //interrupt on falling edge
  PORTB=1;
  TRISB = 0x1;  //INTO pin set for digital input
  INT0IE = 1;   //Enable INT0 interrupt
  INT0IF = 0;   //needs to be reset in either ISR
  TMR1IE=1;    //TMR1IF is manually set along with INT0IF in this test program

  IPEN=1;        //Interrupt Priority Mode enabled
/* NOT NEEDED
  PEIE=1;
  PIE1=1;
  PIE2=1;
*/
  GIEL=1; //enables lo-priority IRQs
  GIEH=1; //enables Lo and Hi priority IRQs, if off, all IRQ's are disabled
//----------------------------------------------------------------------
  Start:
  for(ttemp=0;ttemp<120000;ttemp++)//An approx  several seconds timed loop at 16MHz x 4
   { bbit7=1;         
                      //There is a a 1K resistor connected to each LED to Vss, bbit7 LED is just a heartbeat             
     INT0IE=1;
     TMR1IP=1; //For this timed interval TMR1 is hi-priority
     if(bbit0==0)TMR1IF=1; //Manual sets both IRQ flags with a sw.
                                         //During this interval, only bbit3 should toggle with a debounced sw. press
   }
  for(ttemp=0;ttemp<120000;ttemp++) //Takes about  several seconds at 16MHz x 4
   {
     bbit7=0;  //during this timed interval bbit4 should toggle with each clean sw press

     INT0IE=0;
     TMR1IP=0; //During the SW timed interval, TMR1IF is low-priority
     if(bbit0==0)TMR1IF=1;  //This still triggers INT0IF even if it's interrupt is disabled
   }
  goto Start;
}
//========================   END of MAIN   ==================================

[senso]

Senso, I just clicked on the link posted about this bargain.

The link shows:
Price: £43.57

Still far away from 500$

[SuzyC]

More like $USD 64.40 + shipping+customs+tax, still looks like a $100 deal, and that will fill a lot of diapers for my baby, and shipping adds  a wait as well

 I made a very bad guess about the exchange rates.

[Skimask]

In any case, if I had a pickit2 or 3 or whatever, if my dog decided the plastic thing was tasty or if I somehow managed to blow its #@#7@! brains out I wouldn't be able to fix it myself and would have to wait another 1 to 2 months for another or pay a king's ransom to buy one locally.

Except that Microchip has all of the schematics, code, etc. all posted in the manual PDF.
And how long have you spent on this anyways? A month?  Two months?  A year?
Is your hours and hours of messing around trying to get a homemade thing to work worth that little that a ~$50 programmer isn't worth it?
2 months for shipping?  Surely you haven't looked around hard enough to find a PICKIT2/3 clone.  I've got 4 on the bench next to me, one each authentic Microchip PICKIT2 and PICKIT3, and one each knockoff clone PICKIT2 and PICKIT3.  Both of the knockoffs had to get code updates.  No problems there.
Just buy one that works and get on with it...

[senso]

More like $USD 64.40 + shipping, still looks like a $100 deal, and that will fill a lot of diapers for my baby, and shipping adds  a wait as well

 I made a very bad guess about the exchange rates.

Mouser as PicKit's, as does Digikey, and in the USA you get free or next to free shipping!
48$:
http://www.digikey.com/product-detail/en/PG164130/PG164130-ND/2171224

51$:
http://www2.mouser.com/ProductDetail/Microchip-Technology/PG164130/?qs=sGAEpiMZZMtqy0n2JbDgYFNAcWahhP9A

If your Pickit3 breaks(and it wasn't a massive short caused by user), you open a ticket and Microchip sends you a new one and a pre-paid letter to send them the broken one.

[SuzyC]

It was worth every second.

I learned a lot about programming, troubleshooting, RTFM, PIC18FxK22 chips, and I have something that is truly my own creation, with some many thanks of course, to all those who were so kind to give me a hint now and then.

Now I can edit, compile, program, verify, set fuses, all with one mouse click.

And if it needs repair, I know it is so easy to fix, only need to keep a few LSTTL gates around for spares.

If I don't like the way it works, I can change it anytime I want.

No money spent, no unreliable USB connections, no begging Microchip for updates..no waiting for a slow boat to and from China.

PRICELESS!

[Bruce Abbott]

I think my programmer is working properly,

Yes. I simulated your hex on MPLAB and it misbehaved as you described, indicating a coding error.

So it appears that your programmer is actually working fine. Are you willing to share your final VB code with us? I would like to try making a programmer using your code, for a computer that is not PC compatible but can run programs written in BASIC.
     

[22swg]

Full marks for your DIY  programmer . most like me , go the easy way.....
 

[SuzyC]

Abbot, if you don't have PC that is very PC compatible, get one first. In most areas of the developed economy world, most people will pay you to take their older 486, AMD ATHLON 64 or even a socket 775 processor-based machine off their hands. On my workbench, I am using a 486 2.8GHz 1-meg fastcache, 1GB DDRAM supported single core processor small-profile HP desktop that was discarded and it works great and it was free and programs a chip as fast as PICKIT3.

[SuzyC]

Hey thanks again for the complement, 22swg,

To each their own, people climb a mountain not because it is necessary, not to play bridge at the top, but to enjoy the climb, the challenge that somehow they've might get there, despite the mountain, and with the profound discouragements of friends, employers and family, they somehow managed to get to the top.
 
Perhaps Kennedy could have said in the thick of the space race with the USSR, "We will go to the moon, not because it is easy, but because it is hard!..Therefore I have decided we will hire the Chinese to do it for us and I will save our country trillions of dollars!"

BTW, you recommended that I chose a chip on a stick approach, do you think that would have been a better faster MCU choice than the PIC18 I decided was more compatible with working the way I liked?

[22swg]

Hi, Suzy ..each to his own I guess , It was just that you seem to like to type code like its going out of fashion , not looked at PIC18 much ,thinking you will hit a wall . Is this still the robotics ?     

[picandmix]

Full marks for your DIY  programmer . most like me , go the easy way.....
 

Yes, +1 on that, well done.

However , without being negative,  I feel your efforts may not hold long term when you want to move to other ranges of chips from MC.
Also the parallel port will probably soon be obselete even on desktops.

A real downside you may not yet appreciate is that your programmer cannot perform any hardware debugging;  that can be an extremely useful function.

Am sure you feel happy with your 486, and I have often been accused of being a luddite in respect of PCs , but feel you really are missing out on some of the better aspects , like improved secuirty, ability to run some of the very good free modern programs like Studio8 etc.

XP does sometimes have USB problems, but since I moved from XP to W8 I've never had any such trouble and am using many different usb devices.

If you can find a Pentium based base unit, does not have to be an i Core even a lowly Core 2 Ennnn will do, with W7 or W8 for free or very little , then you will see a dramatic improvment over the 486, not just in speed but in what new work you can do on it.

[SuzyC]

Thanks for your concern, picandmix.

I can only work with one or two different MCU's at a time, and I don't see a problem modifying my programmer's code to adapt to any new candidates to play with, now that I know how to do this easily.

I would as soon give up PC's altogether than submit to  using Win8, pure garbage, and I am just one of millions of others that agree to that, turns a powerful PC workstation into a toy smartphone that has a most obnoxious, clumsy  user interface that makes it so damn hard to anything other than  email, Twits,  Facebook and download XXX. For doing anything serious with a computer, Windows XP or Win7 is still  the best. I don't do Studio 8  video or Fruitloops or Flash with Macromedia, I do flash code. I have the bench PC networked so I can program on my fast PC and my compiler just copies the .hex file to the 486 to program the chip at my work bench. I make my music on my guitar or piano.

The 486 PC is just a handy tool on my workbench, I have made a Parallel port debugging tool that works so well with it. It is plenty fast enough for what I ask it to do and I have a super fast desktop for code generation and other tasks.

I am not at all worried about the parallel port being becoming obsolete, there are many add-on cards to offer even faster Parallel Port performance on a PCI express or PCI addon card. The Parallel Port is so simple an outside world interface, absolutely stable and my programming .exe can be invoked and programming within microseconds, it is fast and crash-free and I love it for that.

Don't get me wrong, I not a USB hating Ludite,  I have USB headphones, USB mouse, USB laser printer, USB this and USB that, its plenty good enough for toy tasks.

[Bruce Abbott]

Abbot, if you don't have PC that is very PC compatible, get one first.

I have four PCs and a PICKIT2, so I don't need another programmer. However I also have an NEC PC8201A (http://www.hembrow.eu/personal/necpc8201a.html) which I use on the workbench. For this purpose it has several advantages over a modern PC - TTL level serial and parallel ports, BASIC and TELCOM in ROM (boots instantly!), and a four cell AA battery which runs it for 8 hours and keeps the current session in RAM for up to 3 months on standby.

25 years ago I used a PC8201A for programming PABX systems. Today retro computing is my hobby, and I want see what I can get these old machines to do with the aid of cheap new hardware (stuff that would have cost an arm and a leg 20 years ago). I like using BASIC for interacting with projects via the parallel port. No waiting several minutes for the PC to boot up and load a bloated IDE. No need to compile and download firmware. No overly-protective operating system getting in the way. Just type 'OUT port, number' and get instant results!
               

[SuzyC]

Good Show, Abbott.

My program is written in VB6 which is its own way is simulating a C-language appropriate task, but in any case, when dealing with VB, you need a PC with XP to do the job. You can take a look at my other earlier postings here that show most of my programming code written in VB6, but an attempt to program a 32K or 64K flash mem of a MCU in BASIC would be painfully slow, if it at all could handle a 32K to 64K array that cache the converted .hex file bytes for programming and verification, memory dumps, etc.