Electrolysis, I am sure, also plays a part in corrosion. Different components may use different metals which could contribute. It's not so much the 'off the shelf' part, it's the part that claims like "Weather resistant" should be able to handle more than a 2 year lifespan inside. So making it myself gives me A) exactly what I want, B) helps me learn what is going on, C) gives me a lot more satisfaction, D) allows me to fix it if something goes wrong later.
On one project, I used the nail polish method & some shoe-goo to protect (or pot) all the components from vibration and it's installed on a motorcycle and has held up very well; it is not well protected, gets moisture, water splashes, rain, etc. and has held up rather well. The wire at the far ends are the only thing that have given me a problem so far.... so I think for inside a shed or under the overhang where it never gets water on it, it will hold up, provided I don't run into an electrolysis issue.