Assembly, Atmega 328 PWM, phase correct mode - out of range problem

[Mikelinius]

Hi,
I'm new into assembly and I need to generate in PWM, phase correct mode signal with frequency 255 Hz and FF 55 % but I have problem with Atmega328 - you can see in the screen what is wrong. But what's more - my code works for Atmega32. It looks like I use some kind of bad instruction, but I've no idea what exactly is wrong. Do you have any idea what's wrong?

.include"m328def.inc"

SBI DDRB, 3
LDI R16, 140 // Fill factor 140/255 = 55%
OUT OCR2A, R16

LDI R17, 0b00000001 //PWM PC
out TCCR2A, R17
LDI R18, 0b00000101 //prescaler 128
out TCCR2B, R17

loop:
rjmp loop

[Kleinstein]

The newer Megaxx8 have many of the registers at different locations and some of the timers get out of the range of the OUT instruction. So one would need to use STS instead.
For some reason they had (not sure if fixed) some of the examples in the datasheet also wrong in this aspect.

Some of register names also changes, though to a large part same funtionality as the mega32.

[Skashkash]

The newer Megaxx8 have many of the registers at different locations and some of the timers get out of the range of the OUT instruction. So one would need to use STS instead.
For some reason they had (not sure if fixed) some of the examples in the datasheet also wrong in this aspect.

Some of register names also changes, though to a large part same funtionality as the mega32.

Was about to say exactly the same.
I've taken to using the following macros so I don't have to keep track of the register address.
(These may not be appropriate for the more modern chips or newer versions of studio.) 

Code: [Select]

;--- in for any port address           
.macro   in_reg                       
.if    @1<0x40                     
    in @0,@1                   
.else                                 
    lds @0,@1                   
.endif                                 
.endm                                 
   
;--- out for any port address         
.macro   out_reg                       
.if @0<0x40                     
out @0,@1                   
.else                                 
    sts @0,@1                   
.endif                                 
.endm