Fair enough, you guys kept speaking about bent sheet metal - I thought the material was stainless steel, it is what most of the manufacturers we looked at suggested for bent sheet metal. What is the material, then?
I think they saw you coming.
I'd avoid anybody who blindly suggested stainless to you without you having given them a good reason to suggest it and I suspect you didn't. It's an inherently more expensive material and harder to work with than plain old mild steel which is what is probably most appropriate for your use. Kind of smells of 'sharp' business practices to me.
If something like the Behringer case you linked to is what you want, then you're looking for simple mild steel, perhaps a passivated version of mild steel such as Zintec, finished by powder coating.
The cheapest way to manufacture cases like this, once you get beyond a certain minimum quantity, is for someone to create a set of stamping dies that will cut, out of cheap flat sheet metal, the outline of your flat case parts, including punching any connector, control, ventilation, and even screw holes in one operation. That's followed by a few simple bending operations, optionally some spot welds where corners fold over and then powder coating. Probably followed by silk screening to get any labelling you need. That will get you the minimum per case material and manufacturing costs, but with the NRE cost of the dies as an upfront cost. The exact quantity breakpoint where this becomes the cheapest option is going to depend on the complexity of the case (number and type of holes etc.).
At the other end, quantity wise, any competent machine shop that does sheet metal work will be able to fabricate individual cases by cutting out sheet metal stock, drilling and punching out individual holes, and folding the flat parts on a box and pan folder. Your cost per case will be much higher, but there aren't any NRE costs.
Cases made from die stamped parts are likely to be more consistent than individually fabricated cases.
Powder coating costs will roughly be the same at both ends of the scale. Screen printing costs will also be similar at both ends of the scale with the caveat that there's some setup costs to any screen printing run, which makes long runs cheaper per unit.
Anything that involves 'proper' machining operations such as drilling or milling individual holes and openings, to modify existing stock cases is going to be more expensive because those operations have to happen to
each and
every case you have made. It's cheaper overall below a certain minimum number, but once you get to a certain number then it's better to invest all that 'proper' machining into manufacturing dies rather than individual cases.
The same logic applies to the dies for making custom aluminium die cast or extruded cases. Those are an inherently more expensive option, both for dies and basic manufacturing, and for the fact that you're unlikely to get a finished case without doing some further machining to the, already custom, case for those processes. If you start with stock cast or extruded cases, then the per case machining costs are all unavoidable and therefore higher still.