Its pretty much essential if you work with BGA a lot and want to be able to verify solder joints etc, maybe not on every board but at least a sample. On automotive or other critical systems you might also have requirements for minimum % voiding under large contact areas, standard process often have much lower actual inter metallic contact than you might think and even careful layout, paste choice and stencil design struggles to meet some of these standards, at that point reflow with vacuum starts to become necessary and you need X-Ray to inspect/verify it.
So lots of places now have X-ray in-house, its not as expensive as it used to be and there are also places that will do it for you.
Some folks on here I believe have scored low powered X-ray units of fleabay, while not designed for this purpose they can see through at least some electronics assemblies but whether they can get through a potted thing is another question...
I guess it depends how many units have failed and what they are worth. We pot a few things, we expect some failures after potting, typically through failed seals, maybe the manufacturing defect / test miss.