The best microcontroller for any project is really determined by specific application requirements, like
- low power, esp. if battery powered (active CPU power, sleep power w/ 32.768 kHz crystal)
- wakeup time from sleep, if using power-saving modes
- low cost
- processing speed - general program flow
- processing speed - math (multiply, divide, 16/32 bit math)
- RAM and flash storage requirements
- flexibility to swap out the MCU with other footprint-compatible parts with more or less memory etc.
- I/O peripherals
- toolchain and code library support
- interrupt handling capability (e.g., MSP430/AVR is much better than PIC 8-bit)
Personally, I think MSP430 gets almost everything right. PIC has a lot of options because there are so many parts, and Microchip has an outstanding record of maintaining long-term supply for parts; however, the lack of a decent free compiler for the 8-bitters and the single interrupt (or two-interrupt for PIC18) make it less somewhat less attractive. AVR is a bit cleaner architecture than PIC in some ways, but there is less flexibility in each package to scale up and down the range (contrast with e.g., 8-bit PIC in 28-pin SSOP/SOIC/DIP where you can go from cheapo PIC16 up to a decently big PIC18 w/ 128KB flash). ARM Cortex-M3/M0 is a great option and is a super clean architecture, but for battery-powered applications that need very low average power, you have to spend several dollars to get a part (e.g., STM32L or Energy Micro EFM32); the cheapest $1.00 to $2.00 processors can't touch the MSP430's low power.
In all, the MSP430 Value Line is really awesome. Great clean architecture that makes compact code, with a powerful and totally free compiler (gcc). I just wish there was a footprint-compatible option with more than 512 bytes of RAM. You have to just up to QFN/QFP packages in the MSP430F5 line to get more RAM, and then there is no compatible low-cost (e.g., $1.00) option. The problem is that at the start of a project, you might not know for certain how much RAM you'll need, as requirements ALWAYS change during a project.