Thanks for the reply! I would like to eventually opensource this as part of a larger project, so im ready to give full information. But realistically, who'd read a really long paragraph?
1. What’s the motivation for all the ESD protection diodes? My gut feeling is that ESD protection on things like the “door switch” interface is total overkill.
This is a one-off board to be handed to a university with people probably way too busy to be able to diagnose an ESD fault when someone eventually opens the case and touches something. It is supposed to last 4-6 years as a minimum, so throwing $10 of ESD protection is a worthy investment.
2. It looks like the solenoid is a low-side FET PWM control. Are you using a TVS diode on the low side to sink the back EMF? I’d put an anti parallel diode across the solenoid instead.
Thats the product of a very long thread with the wonderful T3sl4co1l. The TVS diode will be as good or better than a flyback diode because a flyback diode only concerns itself with the inductor, not the stray inductances of wires and traces.
3. It looks like you are filtering the tachometer signal to get an analog signal. Are those corner frequencies right? The 318Hz filter (per the note) is not a 318Hz filter. I would also consider reducing R and increasing C, 5nF is kind of small in my opinion. I’d aim for 100nF.
Good catch! You are right. That note is indeed inaccurate, it is left over from a previous revision. The filtering done throughout this PCB is because there are multiple 2W 860 MHz RFID antennas close by, and I don't trust ill shield it all properly. All lines that go to long wires are filtered to a frequency that shouldnt cause interference but otherwise maintaining the original signal. Previously, I was trying to just get the signal and was told that this is excessive (this is a 100 Hz signal).
but I’d like to understand why a 41MHz filter is necessary
It really isnt. The resistor is needed either way to protect the microcontroller from a short circuit, and I do not want to get into ferrite beads for my first PCB (this thing has been in the making for ages now, oh and the signaling includes a 300 ns pulse)... I consider that 8.2 puff cap to be a good luck charm

5. I’m not grasping your note about the crystal oscillator ground. There will be common mode current injected from the crystal into the controller. If you do not provide a low inductance return path, it will find one on its own (and emit some radiation for the trouble).
Well, the lowest inductance path to the ground plane is a large via, so I hope that is enough? The microcontroller has a GND pin right next to the XTAL pins, what that notes says is that the GND used for the crystal casing and the load capacitors should connect to that pin, and no other signal goes into that GND via. As you see in the screenshot, the GND pin adjacent to XTAL has only the crystal and its capacitors on it, not even the decoupling capacitors.
Thanks for the reply, ill ammend the filter notes now
