The cheap RC type generators may need an external counter (could be the scope) to get an accurate frequency reading. It may still drift quite a bit even if there is a digital reading (and still set the frequency via pot). How accurate the analog scale is, depends, but often it's more like +-5 or 10%, with switches for the decade and a pot inside the decade.
There is still one point where an analog generator may be better than the cheap modern DDS type ones: this is the triangle waveform, especially if use in a kind of differentiating circuit. The DDS type triangle is usually just some stair steps - sometimes visible in the cheap (e.g. < $60) ones.
The user interface also depends on the use - sometimes adjustment with a pot is more suitable than digital adjustment.
There may be a few other point's that an old analog generator may offer and some cheap DDS one miss, like the option to use it as an VCO, do sweeps (wobble) , maybe more powerful output or parallel sine and square outputs.
Generally even the simple DDS Generators are not that bad and can do most things better. Especially the frequency is more stable and accurate.