Photonic computer will never ever replace transistors.
There are a ton of technical challenges to make photonic computers that are anything like general purpose -- constructing gates is hard, constructing registers/memory is hard, attenuation is high, and integrating sources (LEDs or lasers) is hard. Most photonic stuff is actually pretty slow.
But the insurmountable problem is that photons are just too big. Intel is having a ton of trouble moving from their 14 nm process to a 10 nm process. They have a 7 nm process on their roadmap. The wavelength of 405 nm light in silicon is 120 nm, while in SiO2 it is 270 nm. So it just won't be possible to reach the same level of integration as silicon chips already do -- the photonic structures are just going to be too big.
Photonic processing is interesting for applications like optical networking switches if you can avoid the transition from optical -> electronic -> back. An CPU replacing a modern Intel/AMD is crazy talk.
A lot of the stuff they talk about with "rethinking the way computer work" and making them parallel, pipelined, and so on are all things that we could be doing (or are doing) with silicon processors but it is actually really hard to program for and only useuful in certain applications -- particularly when you have very little data dependence.