Code Review Tools

[Sal Ammoniac]

Can anyone recommend a good tool for conducting code reviews? We need something that makes it easy to generate diffs and distribute them to a small group of reviewers to solicit their comments and track them to closure. Something that interfaces easily with Subversion (or Git) would be ideal. Even better if it interfaces to Polarion.

We've tried Phabricator, but it's too large and unwieldy for the kinds of code reviews that we do.

[Fred27]

Pull requests tend to work well for this. How are you hosting your git repo? I use Microsoft TFS to host the git repo and that works nicely with diffs, comments, merging, etc.

[sd]

Have you tried gerrit ?

[mngiggle]

Our software lead and us electrical guys have evaluated and are just getting going using Collaborator: https://smartbear.com/product/collaborator/overview/.  Seems like a good tool, but it's too early to tell how good.

[newbrain]

At work, we use gerrit, whch is well integrated with git and the CI tools.
Though I personally don't write code, I'm often involved in the reviews: the process does work and I did not hear any major complaint from the development teams.

One can give a -2 to +2 vote on a patchset (or a restricted range, depending on the role),  and edit the code in place to propose changes.
You can of course subscribe for changes to a repo, or use an RSS feed.

The size of our projects is in the order of 100kLOC each.

[MarkF]

I use WinMerge for Windows.   

http://winmerge.org/about/

[rollatorwieltje]

We use ReviewBoard with SVN. I didn't install it myself, but apparently it wasn't that hard. Someone did make a tool (can't share it unfortunately) to post proper diffs, the built-in functionality for creating a review is a bit crude.

[kcbanner]

The Github pull request interface is quite good. We've used it for years where I work.

[mac.6]

Can anyone recommend a good tool for conducting code reviews? We need something that makes it easy to generate diffs and distribute them to a small group of reviewers to solicit their comments and track them to closure. Something that interfaces easily with Subversion (or Git) would be ideal. Even better if it interfaces to Polarion.

We've tried Phabricator, but it's too large and unwieldy for the kinds of code reviews that we do.

Definitely gerrit if you are using git, for subversion I have no experience.

[IanB]

Another suggestion for SmartBear Collaborator here.

It is simple and easy to use, and interfaces with many tools including Git and Subversion.