how to solve the code problem when i made music Fire alarm by arduino?

• how to solve the code problem when i made music Fire alarm by arduino?
  Posted by david-electrical on 27 May, 2016 09:37
• When i made music fire alarm by arduino,i met a problem,the errow shows: empty character constant
  
  the sensor perception the fire,then ARDUINO control buzzer,when fire closer then music to alarm
  
  int flame=A5;
  int Beep=9;
  int length=15;
  char notes[]="ccggaagffeeddc ";
  int beats[]={1,1,1,1,1,1,2,1,1,1,1,1,1,2,4};
  int tempo=300;
  
  int val=0;
  void playTone(int tone ,int duration)
  {
  for(long i=0;i<duration*1000L;i+=tone*2) {
  digitalWrite(Beep,HIGH);
  delayMicroseconds(tone);
  digitalWrite(Beep,LOW);
  delayMicroseconds(tone);
  }
  }
  void playNote(char note,int duration )
  {
  char names[]={'c','d','e','f','g','a','b','C'};
  int tones[]={1915,1700,1519,1432,1275,1136,1014,956};
  for(int i=0;i<8;i++)
  {
    if(names==note)
  playTone(tones,duration);
  }
  }
  void setup()   
  {
    pinMode(Beep,OUTPUT); 
  pinMode(flame,INPUT);
  Serial.begin(9600);
  }   
  void loop() {
    val=analogRead(flame); 
  Serial.println(val); 
  if(val>=600) 
  { digitalWrite(Beep,HIGH);
     for(int i=0;i<length;i++)
     {
    if(notes=='')
  delay(beats*tempo);
    else
    playNote(notes,beats*tempo);
    delay(tempo/2);
     }
  }
  else {
    digitalWrite(Beep,LOW);
       }
  }
  
  
  
• #1 Reply
  Posted by Mechatrommer on 27 May, 2016 10:01
• 1st thing 1st.. make proper indentation...
• #2 Reply
  Posted by obiwanjacobi on 27 May, 2016 10:13
• Code: [Select]

  int flame = A5;
int Beep = 9;
int length = 15;
char notes[] = "ccggaagffeeddc ";
int beats[] = { 1, 1, 1, 1, 1, 1, 2, 1, 1, 1, 1, 1, 1, 2, 4 };
int tempo = 300;

int val = 0;
void playTone(int tone, int duration)
{
    for (long i = 0; i<duration * 1000L; i += tone * 2)
    {
        digitalWrite(Beep, HIGH);
        delayMicroseconds(tone);
        digitalWrite(Beep, LOW);
        delayMicroseconds(tone);
    }
}
void playNote(char note, int duration)
{
    char names[] = { 'c', 'd', 'e', 'f', 'g', 'a', 'b', 'C' };
    int tones[] = { 1915, 1700, 1519, 1432, 1275, 1136, 1014, 956 };
    for (int i = 0; i<8; i++)
    {
        if (names == note)
            playTone(tones, duration);
    }
}
void setup()
{
    pinMode(Beep, OUTPUT);
    pinMode(flame, INPUT);
    Serial.begin(9600);
}
void loop()
{
    val = analogRead(flame);
    Serial.println(val);
    if (val >= 600)
    {
        digitalWrite(Beep, HIGH);
        for (int i = 0; i<length; i++)
        {
            if (notes == '')
                delay(beats*tempo);
            else
                playNote(notes, beats*tempo);
            delay(tempo / 2);
        }
    }
    else
    {
        digitalWrite(Beep, LOW);
    }
}
• #3 Reply
  Posted by hendorog on 27 May, 2016 10:39
• I think line 44, which is:
  

  Code: [Select]

  if (notes == '')

  should instead be this:
  

  Code: [Select]

  if (notes[i] == '')

  Same issue on line 25 as well
  

  Code: [Select]

  if (names[i] == note)

  Edit: And line 47
  

  Code: [Select]

  playNote(notes[i], beats*tempo);

  Edit: and there is another one too, but you can find that one
• #4 Reply
  Posted by botcrusher on 27 May, 2016 12:07
• I just want to point out that in most jurisdictions this is 100%  against fire code
  even presuming your code is bullet proof, until you have it actually approved by a fire marshal / your local group residing over fire law, this is a big nope.
• #5 Reply
  Posted by dannyf on 27 May, 2016 12:44
• Quote

  music fire alarm

  
  That's an interesting innovation we can live without: soothing and comforting music when the fire is raging.
• #6 Reply
  Posted by botcrusher on 29 May, 2016 04:29
• Interestingly, HK fire code has a section on alarm parameters, of which one condition is that it is of a certain tone so that it remains recognisable. Making it sing a tune violates that, and removes the urgency from the alarm. Who would exit the building to a hood song?
• #7 Reply
  Posted by jnz on 29 May, 2016 05:09
• Quote from: botcrusher on 29 May, 2016 04:29

  Who would exit the building to a hood song?
  

  
  Im fairly sure you meant GOOD song... But I want to beleive you really meant hood song. In which case I look forward to the dual discussions about STM F0 vs NXP 1100 peripheral sets while making analogies to Kendrick's Maad City and Alright, or Lupe Fiasco's Prisoner 1&2, or even what "hood" means in terms of good or bad and if JCole is "hood" still despite Role Modelz being excellent or if something more oscure like Tech N9ne is "hood"-enough.
  
  
• #8 Reply
  Posted by Mechatrommer on 29 May, 2016 06:16
• just a suggestion...
  
  (ps: i'd be surprised if someone come edit this post saying this is a weird and dangerous advice...)
  
  
• #9 Reply
  Posted by botcrusher on 29 May, 2016 19:09
• Oh lol. Yes, i meant "good"
  But that's hilarious 
• #10 Reply
  Posted by timb on 29 May, 2016 19:33
• Quote from: Mechatrommer on 29 May, 2016 06:16

  just a suggestion...
  
  (ps: i'd be surprised if someone come edit this post saying this is a weird and dangerous advice...)
  

  
  But... Don't you want to know why we keep starting fires? It's my desire! (My desire!) Danger! Danger! High Voltage! When we touch, when we kiss! Fire in the disco, fire in the disco! Fire in the...Taco Bell... Fire in the disco, fire in the gates of hell! Danger, danger! High Voltage...
  
  https://youtu.be/2a4gyJsY0mc
• #11 Reply
  Posted by stmdude on 29 May, 2016 19:51
• The "empty character constant" message comes from code like this:
  

  Code: [Select]

  a = '';
  Note that there isn't a character inside the single-quotes. That's not allowed in C.
  In your code:
  

  Code: [Select]

  if (notes == '') you're basically comparing with nothing.
  
  

  Quote from: dannyf on 27 May, 2016 12:44

  That's an interesting innovation we can live without: soothing and comforting music when the fire is raging.
  

  Music to die for/by?