Perfectly cromulent code ;)

[TbayBoy]

This should pass review

[brucehoult]

Uhhh .. shouldn't setting up those triggers be in init code, not the handler? Is it even the handler? It's not declared as such. Is it called from the actual handler?

I see no evidence of "sets system flags for the state machine".

Also bounce bounce bounce ... bounce your boooton.

[SiliconWizard]

This should pass review because there are comments? 

We indeed don't know why the code:
- Disables the interrupt upon entry and re-enables it at the end (most MCUs I've ever seen can't retrigger the *same* interrupt while being serviced anyway). Might be an odd MCU, or useless code.
- Indeed setting up the interrupt on change inside the handler doesn't seem to make sense either, unless it's maybe set up differently before the handler is called, but at least one of the edge would be enabled anyway, so it's useless to configure both in the handler.
- Doesn't do anything useful except clear the interrupt flags. (Looks like the only thing actually useful there.) We can assume that's an interrupt handler as it does clear the interrupt flags in there. But maybe it's not.

I wonder where the OP got that piece of code from. Could be fun to know. Might be fully made up to have a laugh. Or maybe code from a coworker.

[uer166]

Love that the comments are all some form of
bool flag = true: // sets flag to true

With 0 useful info

[Ice-Tea]

I don't code. Butt my guess as to why the OP was triggered is much easier..

[westfw]

Love that the comments are all ... 0 useful info

I disagree.  The comments describe the actual function of the incomprehensible register/bit names ...
(assuming that they're accurate!)

[Perkele]

One of benefits working at small companies is that you still can get away with internal project name acronyms like A.R.S.E or F.A.T.
It would be worth explaining to sales that joining those two otherwise completely unrelated projects would leave a humongous imprint on the market.

[mikerj]

I don't code. Butt my guess as to why the OP was triggered is much easier..

Hey, no kink shaming   

[sparkydonkey]

perkele its not the same kind of subject but you might be amused by the fact that apple actually had the codename LAW for one of their early powermacs before

take a guess what LAW was actually an acronym for?
Lawyers Are Wimps.
don't believe that? well sorry but its true history!!

[5U4GB]

One of benefits working at small companies is that you still can get away with internal project name acronyms like A.R.S.E or F.A.T.

Not just small companies. I once had an ICL engineer explain with glee how their mainframe microcode would take a F.A.R.T. in the B.O.G. or something similar.

[0xdeadbeef]

Letting the use of bitfields which was considered totally bad style when I was still developing low level embedded software, I especially like the term "buttpress".
It's like the zenith of using a stupid abbreviation with a somewhat saucy connotation. Exactly what you need in professional software development.

[5U4GB]

It's like the zenith of using a stupid abbreviation with a somewhat saucy connotation. Exactly what you need in professional software development.

It wasn't just software development. Said ICL person had a coworker who kept a tape of recorded flatulence in a desk drawer. if someone called that he didn't want to talk to he'd drop the phone handset in the drawer, press play on the tape recorder, and close the drawer.

This was professional stuff, those guys were thorough.

[dave j]

perkele its not the same kind of subject but you might be amused by the fact that apple actually had the codename LAW for one of their early powermacs before

take a guess what LAW was actually an acronym for?
Lawyers Are Wimps.
don't believe that? well sorry but its true history!!

That reminded me of them using BHA (for butt-head astronomer) as a code name after Carl Sagan objected to them using his name as a code name. It turns out LAW and BHA are related.

[BradC]

Said ICL person had a coworker who kept a tape of recorded flatulence in a desk drawer. if someone called that he didn't want to talk to he'd drop the phone handset in the drawer, press play on the tape recorder, and close the drawer.

Back when answering machines were new and we didn't have caller-id I kept a dictaphone with the recording of a flushing toilet on it. If I got someones machine and I was pretty sure they were just screening calls I'd just play that. I'd like to say I've grown up, but it's probably only caller id and digital voice compression that prevents me from still doing it. The sound of running water makes almost any voice compression algorithm trip over itself and results in completely unrecognisable noise.