Also, judging an architecture that is 30 years old with today's eyes makes little sense.
Are there "better" options these days (define better)? Sure.
Were there at the time it got released? Not that much.
And even without going back to 30 years ago, when Microchip released their XLP series, there wasn't that much competition, and it wasn't that long ago.
Operating temperatures are also a strong point with Microchip MCUs. There aren't that many MCUs that can operate at 150°C reliably.
I have used PIC24 MCUs for high-temperature, low-power designs. Worked great. Yes, also Microchip MCUs have evolved a lot since the first 8-bit PICs.
Now I'm not sure using their "low-end" 8-bitters makes sense anymore *for new projects* considering what's available otherwise, but IMO they can still provide a great learning experience precisely due to their simple, yet quirky ISA. That's great for learning how to design with constraints, something that learning on beefier platforms will never force you to do.